[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Feb 12 01:44:13 UTC 2019


 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv |    2 -
 sc/qa/extras/scdatapilotfieldgroupsobj.cxx                                |   12 ++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

New commits:
commit e0745a11597e5d57eb8001a295314e86810a6027
Author:     Jens Carl <j.carl43 at gmx.de>
AuthorDate: Tue Feb 12 00:50:01 2019 +0000
Commit:     Jens Carl <j.carl43 at gmx.de>
CommitDate: Tue Feb 12 02:43:48 2019 +0100

    tdf#45904 Move XIndexAccess Java tests to C++
    
    Move XIndexAccess Java tests to C++ for ScDataPilotFieldGroupsObj.
    
    Change-Id: I8bd601c2bb8f2c6fa8fe197f31f8df5878aa6b71
    Reviewed-on: https://gerrit.libreoffice.org/67704
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.carl43 at gmx.de>

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv
index 2305453ed41e..9ed530a0ed9c 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv
@@ -1,5 +1,3 @@
-"ScDataPilotFieldGroupsObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScDataPilotFieldGroupsObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
 "ScDataPilotFieldGroupsObj";"com::sun::star::container::XElementAccess";"getElementType()"
 "ScDataPilotFieldGroupsObj";"com::sun::star::container::XElementAccess";"hasElements()"
 "ScDataPilotFieldGroupsObj";"com::sun::star::container::XEnumerationAccess";"createEnumeration()"
diff --git a/sc/qa/extras/scdatapilotfieldgroupsobj.cxx b/sc/qa/extras/scdatapilotfieldgroupsobj.cxx
index 3b504ab85bdd..4459db967dc1 100644
--- a/sc/qa/extras/scdatapilotfieldgroupsobj.cxx
+++ b/sc/qa/extras/scdatapilotfieldgroupsobj.cxx
@@ -8,6 +8,7 @@
  */
 
 #include <test/calc_unoapi_test.hxx>
+#include <test/container/xindexaccess.hxx>
 #include <test/container/xnameaccess.hxx>
 
 #include <comphelper/types.hxx>
@@ -40,7 +41,9 @@ namespace sc_apitest
 {
 const auto nMaxFieldIndex = 6;
 
-class ScDataPilotFieldGroupItemObj : public CalcUnoApiTest, public apitest::XNameAccess
+class ScDataPilotFieldGroupItemObj : public CalcUnoApiTest,
+                                     public apitest::XIndexAccess,
+                                     public apitest::XNameAccess
 {
 public:
     ScDataPilotFieldGroupItemObj();
@@ -51,6 +54,10 @@ public:
 
     CPPUNIT_TEST_SUITE(ScDataPilotFieldGroupItemObj);
 
+    // XIndexAccess
+    CPPUNIT_TEST(testGetByIndex);
+    CPPUNIT_TEST(testGetCount);
+
     // XNameAccess
     CPPUNIT_TEST(testGetByName);
     CPPUNIT_TEST(testGetElementNames);
@@ -64,7 +71,8 @@ private:
 
 ScDataPilotFieldGroupItemObj::ScDataPilotFieldGroupItemObj()
     : CalcUnoApiTest("/sc/qa/extras/testdocuments")
-    , apitest::XNameAccess("Group1")
+    , XIndexAccess(1)
+    , XNameAccess("Group1")
 {
 }
 


More information about the Libreoffice-commits mailing list