[Libreoffice-commits] core.git: qadevOOo/objdsc sc/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Feb 12 06:12:46 UTC 2019


 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv |    2 --
 sc/qa/extras/scdatapilotfieldgroupsobj.cxx                                |    8 ++++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit c9fa173e96190259e7a8747d769232a4c9b842dc
Author:     Jens Carl <j.carl43 at gmx.de>
AuthorDate: Tue Feb 12 00:55:16 2019 +0000
Commit:     Jens Carl <j.carl43 at gmx.de>
CommitDate: Tue Feb 12 07:12:22 2019 +0100

    tdf#45904 Move XElementAccess Java tests to C++
    
    Move XElementAccess Java tests to C++ for ScDataPilotFieldGroupsObj.
    
    Change-Id: Ib43c37dd78fa6b4da87a8c0ccd987bf4ee6879de
    Reviewed-on: https://gerrit.libreoffice.org/67705
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.carl43 at gmx.de>

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv
index 9ed530a0ed9c..d41a5dd13226 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScDataPilotFieldGroupsObj.csv
@@ -1,3 +1 @@
-"ScDataPilotFieldGroupsObj";"com::sun::star::container::XElementAccess";"getElementType()"
-"ScDataPilotFieldGroupsObj";"com::sun::star::container::XElementAccess";"hasElements()"
 "ScDataPilotFieldGroupsObj";"com::sun::star::container::XEnumerationAccess";"createEnumeration()"
diff --git a/sc/qa/extras/scdatapilotfieldgroupsobj.cxx b/sc/qa/extras/scdatapilotfieldgroupsobj.cxx
index 4459db967dc1..0f69233617e5 100644
--- a/sc/qa/extras/scdatapilotfieldgroupsobj.cxx
+++ b/sc/qa/extras/scdatapilotfieldgroupsobj.cxx
@@ -8,6 +8,7 @@
  */
 
 #include <test/calc_unoapi_test.hxx>
+#include <test/container/xelementaccess.hxx>
 #include <test/container/xindexaccess.hxx>
 #include <test/container/xnameaccess.hxx>
 
@@ -16,6 +17,7 @@
 
 #include <com/sun/star/beans/XPropertySet.hpp>
 #include <com/sun/star/container/XIndexAccess.hpp>
+#include <com/sun/star/container/XNameAccess.hpp>
 #include <com/sun/star/container/XNamed.hpp>
 #include <com/sun/star/lang/XComponent.hpp>
 #include <com/sun/star/sheet/DataPilotFieldGroupInfo.hpp>
@@ -42,6 +44,7 @@ namespace sc_apitest
 const auto nMaxFieldIndex = 6;
 
 class ScDataPilotFieldGroupItemObj : public CalcUnoApiTest,
+                                     public apitest::XElementAccess,
                                      public apitest::XIndexAccess,
                                      public apitest::XNameAccess
 {
@@ -54,6 +57,10 @@ public:
 
     CPPUNIT_TEST_SUITE(ScDataPilotFieldGroupItemObj);
 
+    // XElementAccess
+    CPPUNIT_TEST(testGetElementType);
+    CPPUNIT_TEST(testHasElements);
+
     // XIndexAccess
     CPPUNIT_TEST(testGetByIndex);
     CPPUNIT_TEST(testGetCount);
@@ -71,6 +78,7 @@ private:
 
 ScDataPilotFieldGroupItemObj::ScDataPilotFieldGroupItemObj()
     : CalcUnoApiTest("/sc/qa/extras/testdocuments")
+    , XElementAccess(cppu::UnoType<container::XNameAccess>::get())
     , XIndexAccess(1)
     , XNameAccess("Group1")
 {


More information about the Libreoffice-commits mailing list