[Libreoffice-commits] core.git: compilerplugins/clang sw/inc sw/source

[Noel Grandin (via logerrit)]

 compilerplugins/clang/virtualdead.unusedparams.results |    6 ------
 sw/inc/IDocumentRedlineAccess.hxx                      |    4 ++--
 sw/source/core/doc/DocumentRedlineManager.cxx          |    4 ++--
 sw/source/core/inc/DocumentRedlineManager.hxx          |    4 ++--
 sw/source/core/unocore/unocrsrhelper.cxx               |    4 ++--
 5 files changed, 8 insertions(+), 14 deletions(-)

New commits:
commit abb2fced561d0b370b73c658475ce7eb69a11eb7
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Oct 17 14:11:20 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Oct 18 11:16:56 2019 +0200

    lopligin:virtualdead unused params in IDocumentRedlineAccess
    
    Change-Id: I60b343d5e7acb6310e5a0f501f8cfb78dc4ea7a8
    Reviewed-on: https://gerrit.libreoffice.org/81015
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 3573570aa806..dbbf0bd28d62 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -313,12 +313,6 @@ sw/inc/calbck.hxx:144
 sw/inc/IDocumentLinksAdministration.hxx:55
     _Bool IDocumentLinksAdministration::SetData(const class rtl::OUString &,const class rtl::OUString &,const class com::sun::star::uno::Any &,)
     100
-sw/inc/IDocumentRedlineAccess.hxx:168
-    _Bool IDocumentRedlineAccess::AppendTableRowRedline(class SwTableRowRedline *,_Bool,)
-    10
-sw/inc/IDocumentRedlineAccess.hxx:169
-    _Bool IDocumentRedlineAccess::AppendTableCellRedline(class SwTableCellRedline *,_Bool,)
-    10
 sw/inc/swcrsr.hxx:161
     _Bool SwCursor::LeftRight(_Bool,unsigned short,unsigned short,_Bool,_Bool,_Bool,const class SwRootFrame *,)
     1100000
diff --git a/sw/inc/IDocumentRedlineAccess.hxx b/sw/inc/IDocumentRedlineAccess.hxx
index 7592de03411d..7f9eeee6a11e 100644
--- a/sw/inc/IDocumentRedlineAccess.hxx
+++ b/sw/inc/IDocumentRedlineAccess.hxx
@@ -165,8 +165,8 @@ public:
     */
     virtual AppendResult AppendRedline(/*[in]*/SwRangeRedline* pNewRedl, /*[in]*/bool bCallDelete) = 0;
 
-    virtual bool AppendTableRowRedline(/*[in]*/SwTableRowRedline* pPtr, /*[in]*/bool bCallDelete) = 0;
-    virtual bool AppendTableCellRedline(/*[in]*/SwTableCellRedline* pPtr, /*[in]*/bool bCallDelete) = 0;
+    virtual bool AppendTableRowRedline(/*[in]*/SwTableRowRedline* pPtr) = 0;
+    virtual bool AppendTableCellRedline(/*[in]*/SwTableCellRedline* pPtr) = 0;
 
     virtual bool SplitRedline(/*[in]*/const SwPaM& rPam) = 0;
 
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx
index 2372429afc70..d94fec28e868 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -2096,7 +2096,7 @@ DocumentRedlineManager::AppendRedline(SwRangeRedline* pNewRedl, bool const bCall
         : (bMerged ? AppendResult::MERGED : AppendResult::IGNORED);
 }
 
-bool DocumentRedlineManager::AppendTableRowRedline( SwTableRowRedline* pNewRedl, bool )
+bool DocumentRedlineManager::AppendTableRowRedline( SwTableRowRedline* pNewRedl )
 {
     // #TODO - equivalent for 'SwTableRowRedline'
     /*
@@ -2138,7 +2138,7 @@ bool DocumentRedlineManager::AppendTableRowRedline( SwTableRowRedline* pNewRedl,
     return nullptr != pNewRedl;
 }
 
-bool DocumentRedlineManager::AppendTableCellRedline( SwTableCellRedline* pNewRedl, bool )
+bool DocumentRedlineManager::AppendTableCellRedline( SwTableCellRedline* pNewRedl )
 {
     // #TODO - equivalent for 'SwTableCellRedline'
     /*
diff --git a/sw/source/core/inc/DocumentRedlineManager.hxx b/sw/source/core/inc/DocumentRedlineManager.hxx
index dc05f0141b45..a9811827e262 100644
--- a/sw/source/core/inc/DocumentRedlineManager.hxx
+++ b/sw/source/core/inc/DocumentRedlineManager.hxx
@@ -57,8 +57,8 @@ public:
 
     virtual AppendResult AppendRedline(/*[in]*/SwRangeRedline* pPtr, /*[in]*/bool bCallDelete) override;
 
-    virtual bool AppendTableRowRedline(/*[in]*/SwTableRowRedline* pPtr, /*[in]*/bool bCallDelete) override;
-    virtual bool AppendTableCellRedline(/*[in]*/SwTableCellRedline* pPtr, /*[in]*/bool bCallDelete) override;
+    virtual bool AppendTableRowRedline(/*[in]*/SwTableRowRedline* pPtr) override;
+    virtual bool AppendTableCellRedline(/*[in]*/SwTableCellRedline* pPtr) override;
 
     virtual bool SplitRedline(/*[in]*/const SwPaM& rPam) override;
 
diff --git a/sw/source/core/unocore/unocrsrhelper.cxx b/sw/source/core/unocore/unocrsrhelper.cxx
index 0b0555b94c11..05bab4a0c344 100644
--- a/sw/source/core/unocore/unocrsrhelper.cxx
+++ b/sw/source/core/unocore/unocrsrhelper.cxx
@@ -1360,7 +1360,7 @@ void makeTableRowRedline( SwTableLine& rTableLine,
     pRedline->SetExtraData( nullptr );
 
     pRedlineAccess->SetRedlineFlags_intern(RedlineFlags::On);
-    bool bRet = pRedlineAccess->AppendTableRowRedline( pRedline, false );
+    bool bRet = pRedlineAccess->AppendTableRowRedline( pRedline );
     pRedlineAccess->SetRedlineFlags_intern( nPrevMode );
     if( !bRet )
         throw lang::IllegalArgumentException();
@@ -1409,7 +1409,7 @@ void makeTableCellRedline( SwTableBox& rTableBox,
     pRedline->SetExtraData( nullptr );
 
     pRedlineAccess->SetRedlineFlags_intern(RedlineFlags::On);
-    bool bRet = pRedlineAccess->AppendTableCellRedline( pRedline, false );
+    bool bRet = pRedlineAccess->AppendTableCellRedline( pRedline );
     pRedlineAccess->SetRedlineFlags_intern( nPrevMode );
     if( !bRet )
         throw lang::IllegalArgumentException();