[Libreoffice-commits] core.git: compilerplugins/clang sw/inc sw/source

[Noel Grandin (via logerrit)]

 compilerplugins/clang/virtualdead.unusedparams.results    |    3 ---
 sw/inc/IDocumentLinksAdministration.hxx                   |    2 +-
 sw/source/core/doc/DocumentLinksAdministrationManager.cxx |    3 +--
 sw/source/core/inc/DocumentLinksAdministrationManager.hxx |    2 +-
 sw/source/uibase/app/docsh2.cxx                           |    6 +++---
 5 files changed, 6 insertions(+), 10 deletions(-)

New commits:
commit 6c249730d5fc0d50159f68e265957bf0c9887a9a
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Oct 17 14:18:38 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Oct 18 13:39:52 2019 +0200

    loplugin:virtualdead unused param in IDocumentLinksAdministration::SetData
    
    Change-Id: I4d36b56a10266293285b9b7727f3c6bfac23a45b
    Reviewed-on: https://gerrit.libreoffice.org/81016
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index dbbf0bd28d62..5ed7e9cabee5 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -310,9 +310,6 @@ svx/source/inc/fmtextcontrolshell.hxx:69
 sw/inc/calbck.hxx:144
     void SwClient::Modify(const class SfxPoolItem *const,const class SfxPoolItem *const,)
     10
-sw/inc/IDocumentLinksAdministration.hxx:55
-    _Bool IDocumentLinksAdministration::SetData(const class rtl::OUString &,const class rtl::OUString &,const class com::sun::star::uno::Any &,)
-    100
 sw/inc/swcrsr.hxx:161
     _Bool SwCursor::LeftRight(_Bool,unsigned short,unsigned short,_Bool,_Bool,_Bool,const class SwRootFrame *,)
     1100000
diff --git a/sw/inc/IDocumentLinksAdministration.hxx b/sw/inc/IDocumentLinksAdministration.hxx
index fc894ead0200..4bc8c78122a3 100644
--- a/sw/inc/IDocumentLinksAdministration.hxx
+++ b/sw/inc/IDocumentLinksAdministration.hxx
@@ -52,7 +52,7 @@ using rtl::OUString;
     */
     virtual bool GetData(const OUString& rItem, const OUString& rMimeType, css::uno::Any& rValue) const = 0;
 
-    virtual bool SetData(const OUString& rItem, const OUString& rMimeType, const css::uno::Any& rValue) = 0;
+    virtual bool SetData(const OUString& rItem) = 0;
 
     virtual ::sfx2::SvLinkSource* CreateLinkSource(const OUString& rItem) = 0;
 
diff --git a/sw/source/core/doc/DocumentLinksAdministrationManager.cxx b/sw/source/core/doc/DocumentLinksAdministrationManager.cxx
index b9e0e70f1647..9086b9faef74 100644
--- a/sw/source/core/doc/DocumentLinksAdministrationManager.cxx
+++ b/sw/source/core/doc/DocumentLinksAdministrationManager.cxx
@@ -290,8 +290,7 @@ bool DocumentLinksAdministrationManager::GetData( const OUString& rItem, const O
     return false;
 }
 
-bool DocumentLinksAdministrationManager::SetData( const OUString& rItem, const OUString& ,
-                     const uno::Any &  )
+bool DocumentLinksAdministrationManager::SetData( const OUString& rItem )
 {
     // search for bookmarks and sections case sensitive at first. If nothing is found then try again case insensitive
     bool bCaseSensitive = true;
diff --git a/sw/source/core/inc/DocumentLinksAdministrationManager.hxx b/sw/source/core/inc/DocumentLinksAdministrationManager.hxx
index 23bb91778f1a..5c9dcdda079d 100644
--- a/sw/source/core/inc/DocumentLinksAdministrationManager.hxx
+++ b/sw/source/core/inc/DocumentLinksAdministrationManager.hxx
@@ -50,7 +50,7 @@ public:
 
     bool GetData(const OUString& rItem, const OUString& rMimeType, css::uno::Any& rValue) const override;
 
-    bool SetData(const OUString& rItem, const OUString& rMimeType, const css::uno::Any& rValue) override;
+    bool SetData(const OUString& rItem) override;
 
     ::sfx2::SvLinkSource* CreateLinkSource(const OUString& rItem) override;
 
diff --git a/sw/source/uibase/app/docsh2.cxx b/sw/source/uibase/app/docsh2.cxx
index b272ecbf0d91..f94c4e5ac514 100644
--- a/sw/source/uibase/app/docsh2.cxx
+++ b/sw/source/uibase/app/docsh2.cxx
@@ -1347,10 +1347,10 @@ bool SwDocShell::DdeGetData( const OUString& rItem, const OUString& rMimeType,
     return m_xDoc->getIDocumentLinksAdministration().GetData( rItem, rMimeType, rValue );
 }
 
-bool SwDocShell::DdeSetData( const OUString& rItem, const OUString& rMimeType,
-                             const uno::Any & rValue )
+bool SwDocShell::DdeSetData( const OUString& rItem, const OUString& /*rMimeType*/,
+                             const uno::Any & /*rValue*/ )
 {
-    return m_xDoc->getIDocumentLinksAdministration().SetData( rItem, rMimeType, rValue );
+    return m_xDoc->getIDocumentLinksAdministration().SetData( rItem );
 }
 
 #endif