[Libreoffice-commits] core.git: dbaccess/source

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Mon Sep 9 20:57:46 UTC 2019


 dbaccess/source/filter/hsqldb/fbcreateparser.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit f4f8bccbd4e2c3979a83d5b2f49e16a99a3a2016
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Mon Sep 9 22:12:38 2019 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Mon Sep 9 22:57:02 2019 +0200

    Related tdf#127040: fix START WITH
    
    Change-Id: I1dc5223015b787bcc122617d8ad9db6fabad20b2
    Reviewed-on: https://gerrit.libreoffice.org/78787
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/dbaccess/source/filter/hsqldb/fbcreateparser.cxx b/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
index 756b2bd3d445..edb3fcd6cc6f 100644
--- a/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
+++ b/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
@@ -184,7 +184,11 @@ OUString FbCreateStmtParser::compose() const
             // start with 0:
             // HSQLDB: first value will be 0.
             // Firebird: first value will be 1.
-            sSql.append(columnIter->getStartValue() - 1);
+            // but we can't put -1 for Firebird in case HSQLDB begins to 0
+            sal_Int32 nStartValue = columnIter->getStartValue();
+            if (nStartValue)
+                --nStartValue;
+            sSql.append(nStartValue);
             sSql.append(")");
         }
         else if (!columnIter->isNullable())


More information about the Libreoffice-commits mailing list