[Libreoffice-commits] core.git: dbaccess/source

[Julien Nabet (via logerrit)]

 dbaccess/source/filter/hsqldb/fbcreateparser.cxx |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit 2acafef57153bfa1ade59e887a55457ba677b976
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Tue Sep 10 07:17:06 2019 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Tue Sep 10 08:40:41 2019 +0200

    Revert "Related tdf#127040: fix START WITH"
    
    -1 isn't a problem.
    The only pb was record length
    
    This reverts commit f4f8bccbd4e2c3979a83d5b2f49e16a99a3a2016.
    
    Change-Id: I3108e451bf10b2e96dff5eeb040e77feeb67875a
    Reviewed-on: https://gerrit.libreoffice.org/78791
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/dbaccess/source/filter/hsqldb/fbcreateparser.cxx b/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
index edb3fcd6cc6f..756b2bd3d445 100644
--- a/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
+++ b/dbaccess/source/filter/hsqldb/fbcreateparser.cxx
@@ -184,11 +184,7 @@ OUString FbCreateStmtParser::compose() const
             // start with 0:
             // HSQLDB: first value will be 0.
             // Firebird: first value will be 1.
-            // but we can't put -1 for Firebird in case HSQLDB begins to 0
-            sal_Int32 nStartValue = columnIter->getStartValue();
-            if (nStartValue)
-                --nStartValue;
-            sSql.append(nStartValue);
+            sSql.append(columnIter->getStartValue() - 1);
             sSql.append(")");
         }
         else if (!columnIter->isNullable())