[Libreoffice-commits] core.git: o3tl/CppunitTest_o3tl_tests.mk o3tl/qa

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed Jan 13 17:10:39 UTC 2021


 o3tl/CppunitTest_o3tl_tests.mk |    1 
 o3tl/qa/test-temporary.cxx     |   47 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)

New commits:
commit 6ce3e7b615193f610add5428d2157f31600dec52
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Jan 7 14:20:02 2021 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Jan 13 18:10:01 2021 +0100

    Verify o3tl::temporary of a copied lvalue works as expected
    
    Change-Id: I454dd9308e7da4c7be4751eb643395ac483d6c43
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108939
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/o3tl/CppunitTest_o3tl_tests.mk b/o3tl/CppunitTest_o3tl_tests.mk
index 152fa48c72ca..07229a9384b1 100644
--- a/o3tl/CppunitTest_o3tl_tests.mk
+++ b/o3tl/CppunitTest_o3tl_tests.mk
@@ -33,6 +33,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,o3tl_tests,\
 	o3tl/qa/test-safeint \
 	o3tl/qa/test-sorted_vector \
 	o3tl/qa/test-span \
+	o3tl/qa/test-temporary \
 	o3tl/qa/test-typed_flags \
 	o3tl/qa/test-vector_pool \
 ))
diff --git a/o3tl/qa/test-temporary.cxx b/o3tl/qa/test-temporary.cxx
new file mode 100644
index 000000000000..6f775de8473d
--- /dev/null
+++ b/o3tl/qa/test-temporary.cxx
@@ -0,0 +1,47 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <sal/config.h>
+
+#include <cppunit/TestAssert.h>
+#include <cppunit/TestFixture.h>
+#include <cppunit/extensions/HelperMacros.h>
+
+#include <o3tl/temporary.hxx>
+
+namespace
+{
+void modify(int& n) { n = 1; }
+
+class Test : public CppUnit::TestFixture
+{
+private:
+    CPPUNIT_TEST_SUITE(Test);
+    CPPUNIT_TEST(testLvalue);
+    CPPUNIT_TEST_SUITE_END();
+
+    void testLvalue()
+    {
+        {
+            int n = 0;
+            modify(n);
+            CPPUNIT_ASSERT_EQUAL(1, n);
+        }
+        {
+            int n = 0;
+            modify(o3tl::temporary(int(n)));
+            CPPUNIT_ASSERT_EQUAL(0, n);
+        }
+    }
+};
+
+CPPUNIT_TEST_SUITE_REGISTRATION(Test);
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */


More information about the Libreoffice-commits mailing list