[Libreoffice-commits] core.git: sdext/source

Dr. David Alan Gilbert (via logerrit) logerrit at kemper.freedesktop.org
Mon Jan 25 06:55:17 UTC 2021


 sdext/source/presenter/PresenterSlideSorter.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 4e55bf7553fd90639769184e7027f275d31ca0b1
Author:     Dr. David Alan Gilbert <dave at treblig.org>
AuthorDate: Sun Jan 24 02:57:52 2021 +0000
Commit:     Samuel Mehrbrodt <samuel.mehrbrodt at allotropia.de>
CommitDate: Mon Jan 25 07:54:37 2021 +0100

    PresenterSlideSorter::mouseMoved: Merge identical if
    
    cppchecker spotted a pair of neighbouring if's with identical
    conditions; merge them.
    
    Change-Id: I29e13eb5eeca157d06f98c94587167c1a2ddec12
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109850
    Tested-by: Jenkins
    Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt at allotropia.de>

diff --git a/sdext/source/presenter/PresenterSlideSorter.cxx b/sdext/source/presenter/PresenterSlideSorter.cxx
index e87cb442df25..1f8adc555693 100644
--- a/sdext/source/presenter/PresenterSlideSorter.cxx
+++ b/sdext/source/presenter/PresenterSlideSorter.cxx
@@ -541,11 +541,9 @@ void SAL_CALL PresenterSlideSorter::mouseMoved (const css::awt::MouseEvent& rEve
     const geometry::RealPoint2D aPosition(rTemp.X, rEvent.Y);
     sal_Int32 nSlideIndex (mpLayout->GetSlideIndexForPosition(aPosition));
 
-    if (nSlideIndex < 0)
-        mnSlideIndexMousePressed = -1;
-
     if (nSlideIndex < 0)
     {
+        mnSlideIndexMousePressed = -1;
         mpMouseOverManager->SetSlide(nSlideIndex, awt::Rectangle(0,0,0,0));
     }
     else


More information about the Libreoffice-commits mailing list