[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 303c1433005044e3a818490d65385febc8eb6030
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 19 14:15:45 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 19 21:03:47 2021 +0100

    cid#1474031 silence Double free
    
    coverity has learned about GObject apparently
    
    Change-Id: I3ef65407d3463cfd8bc106a8c354f4d8c1710dc8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112748
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index fc958c780f18..6e5e5b48895d 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -3137,6 +3137,7 @@ public:
             gtk_widget_destroy(m_pMouseEventBox);
 
             gtk_container_add(GTK_CONTAINER(pParent), m_pWidget);
+            // coverity[freed_arg : FALSE] - this does not free m_pWidget, it is reffed by pParent
             g_object_unref(m_pWidget);
         }