[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 9e0b747a51fe30c58296c5350214e98d7ecb80a8
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 19 15:13:12 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 19 21:07:22 2021 +0100

    cid#1473912 silence Use after free
    
    Change-Id: Ic4ee4d9cdf5f7f4e1247513b231b2880c1f316c4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112754
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 6e5e5b48895d..52c06df10452 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -6368,6 +6368,7 @@ private:
         g_object_ref(m_pNotebook);
         gtk_container_remove(GTK_CONTAINER(pParent), GTK_WIDGET(m_pNotebook));
         gtk_box_pack_start(m_pOverFlowBox, GTK_WIDGET(m_pNotebook), true, true, 0);
+        // coverity[freed_arg : FALSE] - this does not free m_pNotebook , it is reffed by pParent
         g_object_unref(m_pNotebook);
         gtk_widget_show(GTK_WIDGET(m_pOverFlowBox));
     }