[Libreoffice-commits] core.git: vcl/unx

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Sun Mar 21 19:46:27 UTC 2021


 vcl/unx/gtk3/gtk3gtkinst.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5545fa0b9f88057e8b7ef4405cf15c2096d23691
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Mar 21 14:43:11 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Mar 21 20:45:38 2021 +0100

    cid#1474327 move markup to previous line
    
    Change-Id: I2457ab6ea8159cc3f594042390825ae035bf9d35
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112840
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index c9fe5288ae2f..ec8d970caad3 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -6135,8 +6135,8 @@ public:
         gtk_container_remove(GTK_CONTAINER(m_pScrolledWindow), pViewport);
 
         gtk_container_add(GTK_CONTAINER(m_pScrolledWindow), m_pOrigViewport);
-        g_object_unref(m_pOrigViewport);
         // coverity[freed_arg : FALSE] - this does not free m_pOrigViewport, it is reffed by m_pScrolledWindow
+        g_object_unref(m_pOrigViewport);
         gtk_container_add(GTK_CONTAINER(m_pOrigViewport), pChild);
         g_object_unref(pChild);
         gtk_widget_destroy(pViewport);


More information about the Libreoffice-commits mailing list