[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtk3gtkinst.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 401105d4fc9c5a1746b4d887554b169e023a06c1
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Mar 19 15:22:04 2021 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Mar 19 21:08:42 2021 +0100

    cid#1474327 silence Use after free
    
    Change-Id: I94c355c73a62723987157aecb9b0dbc2431af5af
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112757
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 745934c192c2..c9fe5288ae2f 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -6136,6 +6136,7 @@ public:
 
         gtk_container_add(GTK_CONTAINER(m_pScrolledWindow), m_pOrigViewport);
         g_object_unref(m_pOrigViewport);
+        // coverity[freed_arg : FALSE] - this does not free m_pOrigViewport, it is reffed by m_pScrolledWindow
         gtk_container_add(GTK_CONTAINER(m_pOrigViewport), pChild);
         g_object_unref(pChild);
         gtk_widget_destroy(pViewport);