[Libreoffice-ux-advise] Fwd: [PATCH] fdo#48317 - Support jumping to next/previous change

[Muhammad Haggag]

Hello,

Can you guys look at this change and advise whether it's OK from a UX
perspective? Thanks!

---------- Forwarded message ----------
From: Muhammad Haggag (via Code Review) <gerrit at gerrit.libreoffice.org>
Date: Sat, Nov 24, 2012 at 2:16 PM
Subject: [PATCH] fdo#48317 - Support jumping to next/previous change
To:
Cc: LibreOffice Developer List <libreoffice at lists.freedesktop.org>


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1156

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1156/1

fdo#48317 - Support jumping to next/previous change

Added two new writer commands: NextTrackedChange (FN_REDLINE_NEXT_CHANGE)
and
 PreviousTrackedChange (FN_REDLINE_PREV_CHANGE).
Rewrote the logic for Accept/Reject change (FN_REDLINE_ACCEPT_DIRECT and
 FN_REDLINE_REJECT_DIRECT) to work well with the newly introduced commands.

Change-Id: I03d583bef4225409f69934f16db1854564c2db5f
---
M officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
M scripting/workben/bindings/writermenubar.xml
M sw/inc/cmdid.h
M sw/inc/swcommands.h
M sw/sdi/_viewsh.sdi
M sw/sdi/swriter.sdi
M sw/source/ui/app/mn.src
M sw/source/ui/uiview/view2.cxx
M sw/source/ui/uiview/viewstat.cxx
M sw/uiconfig/sglobal/menubar/menubar.xml
M sw/uiconfig/swform/menubar/menubar.xml
M sw/uiconfig/swreport/menubar/menubar.xml
M sw/uiconfig/swriter/menubar/menubar.xml
M sw/uiconfig/swxform/menubar/menubar.xml
14 files changed, 180 insertions(+), 20 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1156
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03d583bef4225409f69934f16db1854564c2db5f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Muhammad Haggag <mhaggag at gmail.com>

_______________________________________________
LibreOffice mailing list
LibreOffice at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice-ux-advise/attachments/20121124/86ecb05e/attachment.html>