[Libreoffice] [PUSHED] Re: [PATCH] Fix for bug/feature request i#8288

Lubos Lunak l.lunak at suse.cz
Wed Dec 1 06:31:56 PST 2010


On Wednesday 01 of December 2010, Jan Holesovsky wrote:
> >  There appears to be a helper class for this, SwCrsrSaveState. Except
> > that it
> > doesn't seem to work, as far as I can judge SwCursor::RestoreState()
> > doesn't
> > really restore anything (quite hard to say, so much for "trivial APIs
> > don't
> > need docs").
>
> Yeah - I tried to use that one instead when testing the patch, but
> noticed the same thing, so I just pushed the patch verbatim :-)  Do we
> actually use SwCrsrSaveState somewhere (ie. is it worth fixing/removing
> for good/anything else)?  [Actually, I wouldn't be surprised if there
> was a copy somewhere else that works ;-)]

 I've figured it out. SwCrsrSaveState only saves the state on the stack, the 
actual restoring is done by SwCursor::RestoreSavePos(). I'll change the code 
to use it.

-- 
 Lubos Lunak
 l.lunak at suse.cz


More information about the LibreOffice mailing list