[Libreoffice] [PUSHED] Re: [PATCH] Fix for bug/feature request i#8288

[Jan Holesovsky]

Hi Lubos,

Lubos Lunak píše v St 01. 12. 2010 v 15:05 +0100:

> > > Also one of the easy hacks.
> > >
> > > Patch ensures that after doing "replace all" the cursor is left at
> > > original position, rather than moved to the position of the last
> > > replacement.
> >
> > Wow! - what a great usability improvement, with few lines of code
> :-)
> > Pushed, the only change was using the 8288 as the bug number,
> instead of
> > 12345.
> 
>  There appears to be a helper class for this, SwCrsrSaveState. Except
> that it 
> doesn't seem to work, as far as I can judge SwCursor::RestoreState()
> doesn't 
> really restore anything (quite hard to say, so much for "trivial APIs
> don't 
> need docs").

Yeah - I tried to use that one instead when testing the patch, but
noticed the same thing, so I just pushed the patch verbatim :-)  Do we
actually use SwCrsrSaveState somewhere (ie. is it worth fixing/removing
for good/anything else)?  [Actually, I wouldn't be surprised if there
was a copy somewhere else that works ;-)]

Regards,
Kendy