[Libreoffice] [PUSHED] Re: [PUSHED, partially] Re: [PATCH] cppcheck "Common realloc mistake"
caolanm at redhat.com
Mon Nov 1 03:01:00 PDT 2010
On Mon, 2010-11-01 at 09:02 +0100, Gert Faller wrote:
> I was just wondering if freeing some bytes was worth while.
> A patch for this...
Yeah, it's probably a bit expensive to realloc in order to drop a tiny
amount of bytes, but its an unlikely code path anyway so patch applied
and warning silenced :-). Pushed.
Tracing the logic, yes this look good. a failure on realloc will trundle
down past everything else and end up with a return false which is what
we want here. Pushed.
More information about the LibreOffice