[Libreoffice] [PUSHED] Re: [PATCH] +question RTL_CONSTASCII_USTRINGPARAM for calc_core_tools

[Caolán McNamara]

On Thu, 2010-11-11 at 09:29 +0100, Julien Nabet wrote:
> Hello,
> 
> Here's a patch for calc/sc/source/core/tools
> 
> I compiled it and it's ok. Hope it's ok !

It looks good to me, pushed, thanks for this.

> How can we replace createFromAscii in this kind of line :
> OUString::createFromAscii(aPropNames[i])

Can't really, at least not with a trivial change. Could always unroll
the loop and use

OUString::createFromAscii("first one");
OUString::createFromAscii("second one");

etc, but probably not worth it. I suggest skipping those and have a look
at e.g. svtools and svl for loads of easier hanging fruit in some shared
libs if calc is running out of easy ones to fix.

C.