[Libreoffice] [PUSHED] Draw a visible line under the current line

[Jonas Finnemann Jensen]

Hi Luke,

I've pushed your patch, it looks good and works great...
Now there's a chance that users will notice that 3 and 4 are in two
different lines in the following formula: 3 + 4^2
The way the SmSubSupNode works isn't very intuitive for visual editing (at
least compared to MathType), but with this patch people should have a chance
to actually notice this obscurity... Thanks! :)

 I made a couple of methods for SmGraphicWindow, IsLineVisible and ShowLine.
> I made them public, as I would imagine they would be used for number 7 of
> the complex and non-essential tasks on the todo list.

That's a great idea, we will probably need that when trying to address that
issue...
(btw, you're welcome to work on the extra dream feature if you  feel like
it).

As always just move the issue from the easy hacks page, when you're done
with it... :)

Again, thanks for a great patch... That's on more off the todo-list...

--
Regards Jonas Finnemann Jensen.


On Wed, Nov 17, 2010 at 00:43, Luke Dixon <6b8b4567 at gmail.com> wrote:

> Hello Jonas,
> > I think the patch looks great, I've pushed it... But when we need to
> > draw a thin solid line under the visual line that the caret is in, we
> > will probably need to pass a boolean value to SmCursor::Draw in
> > SmGraphicWindow::Paint and from SmCursor::Draw to
> > SmCaretDrawingVisitor... So that only the vertical line blinks, but
> > the solid underline of the visual line doesn't blink...
> > This is as opposed to not calling SmCursor::Draw in
> > SmGraphicWindow::Paint which is what currently happens...
>
> Thanks very much for your help in pointing me in the right direction for
> this.
>
> I've attempted the other easy hack, this information meant I didn't have
> to spend any time working out what to do.
> I made a couple of methods for SmGraphicWindow, IsLineVisible and
> ShowLine. I made them public, as I would imagine they would be used for
> number 7 of the complex and non-essential tasks on the todo list.
>
> > By the way, I think that it's really cool that you found the setting
> > for the caret blink timer... Nice work!
> That was all thanks to opengrok.go-oo.org (thanks for pointing that out
> to me).
>
>
> Regards,
> Luke
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20101117/1cc03c79/attachment-0001.htm>