[Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

Jonas Finnemann Jensen jopsen at gmail.com
Wed Nov 24 08:20:14 PST 2010

Hi Luke,

Nice work! I didn't know there was bugs in SmNodeToTextVisitor, but
somehow it doesn't surprise me...
The format is slightly obscure and the visitor was in need of some love...

By the way, I really like to unit tests... That is a brilliant idea,
unit tests are perfect for this kind of thing.
Must admit I had to ask around to figure out how to run the unit tests...
I have a visitor to testing the visitor implementation, maybe I should
use that in a unit test too...
I wonder if there's anything else we could write unit tests for...
Anyway, it's a good thing to keep in mind..

> This page is licensed with the Creative Common Attribution 3.0 license
> (CC-BY), so I put a note in the code with all the contributors names
> (Hopefully that covers it).
I'm no lawyer, but I think it's LGPL compatible and I really doubt
anybody cares...

>I didn't see any of the other tests doing like this with the
>assertion_traits template and CPPUNIT_ASSERT_EQUAL_MESSAGE, so I hope I
>haven't gone too far.
I haven't used cppunit before, but it looks really cool to me... :)

>I also have a very small patch which removes a couple of things from the
>todo list (maybe it ought to be an unnumbered list, so all the numbers
>don't need changing each time).
Great... And yes, let's remove the numbers next time we update the todo...
They were originally introduced as the todo/readme file was used on
github and formatted with markdown.

Regards Jonas Finnemann Jensen.

On Tue, Nov 23, 2010 at 18:12, Luke Dixon <6b8b4567 at gmail.com> wrote:
>> Sorry, forgot something.
> And of course I forgot to add the attachments :(

More information about the LibreOffice mailing list