[Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

Luke Dixon 6b8b4567 at gmail.com
Wed Nov 24 09:25:35 PST 2010

Hello Jonas,

Thanks for accepting these patches.

> Nice work! I didn't know there was bugs in SmNodeToTextVisitor, but
> somehow it doesn't surprise me...
> The format is slightly obscure and the visitor was in need of some love...

Sometimes the smallest bugs are the hardest to believe. There are times
I can't believe that I've missed such simple stuff. Speaking of which
I've attached another patch for the test I sent :| (though I doubt leaks
in a test matter much).

> By the way, I really like to unit tests... That is a brilliant idea,
> unit tests are perfect for this kind of thing.
> Must admit I had to ask around to figure out how to run the unit tests...
> I have a visitor to testing the visitor implementation, maybe I should
> use that in a unit test too...
> I wonder if there's anything else we could write unit tests for...
> Anyway, it's a good thing to keep in mind..

Ever since I saw that other test added there a couple of weeks ago, I've
been feeling guilty about it and kept wondering if it was put there as a

Thanks again,

More information about the LibreOffice mailing list