[Libreoffice] [PUSHED] Re: SmNodeToTextVisitor Fixes

[Jonas Finnemann Jensen]

Hi Luke,

Just, pushed the two patches... Sorry, that it took a while to get
back to you...

By the way, is the SmNodeToTextVisitor as good as it gets now?
Or is it possible to do more improvements ? and if so, should we leave
as an easy hack we or someone can pickup later? (if not lets remove it
from the wiki).
I don't know how good it is with regards to minimizing the use of
brackets. E.g. if it's realistic to do it any better...

--
Regards Jonas Finnemann Jensen.



On Thu, Nov 25, 2010 at 18:46, Luke Dixon <6b8b4567 at gmail.com> wrote:
> Hello Caolán,
>
>> I suggest you cut and paste the header from
>> http://www.freedesktop.org/wiki/Software/LibreOffice/LicenseHeader
>> into the top of that new file and stick your name in there as the
>> original contributor as it is new code.
>
> Thanks, that means a lot to me. I've attached a patch which does this.
> Though I must mention that I had copied the test you had added and just
> changed some bits.
>
>> As an aside, in the test_starmath.cxx I hope to make it a cppunit
>> build-time test equivalent testautomation/math/required/ and enable it
>> to be built and executed on all platforms. I've been struggling a little
>> bit with converting tests from
>> testautomation/math/required/includes/m_002_.inc e.g. tmEditMarker into
>> a build-time cppunit test given the dependencies that SmEditWindow has
>> on basically a fully functioning Office environment, which I want to
>> avoid. Easiest thing I'm now thinking is to tweak SmEditWindow itself to
>> make it standlone testable.
>
> Unfortunately I think I've jumped in a bit too deep here.
> Looking at SmEditWindow it seems to depend on quite a bit of stuff that
> I don't understand. I think that you are right about tweaking it so it
> doesn't depend on these though, trying to fake the other parts would be
> a nightmare.
> I would offer to help, but I don't think I would know where to begin.
> I'm very sorry.
>
> Regards,
> Luke
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>