[Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

Caolán McNamara caolanm at redhat.com
Thu Oct 14 01:11:26 PDT 2010


On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote:
> http://wiki.services.openoffice.org/wiki/Debug_Levels. 
> 
> Some additional questions. What should I replace DBG_ERROR with?

Hmm, DBG_ERROR takes no condition, and just a message, I suggest that 
DBG_ERROR("horrible failure");
can become
OSL_ENSURE(false, "horrible failure");

> Should RTL_LOGFILE_CONTEXT_AUTHOR as in http://bit.ly/buiBlA be updated
> somehow as it contains a lot of hardcoded e-mail addresses?

*shrug*, nah, leave 'em alone I suggest.

C.



More information about the LibreOffice mailing list