[Libreoffice] [LibreOffice][Patch] Replace ASSERT and DBG_ASSERT with OSL_ENSURE + some translations, comment removal

Cédric Bosdonnat cedric.bosdonnat.ooo at free.fr
Wed Oct 13 14:02:44 PDT 2010


Hi Jacek,

I removed a hunk that wasn't valid, but otherwise, the patch looks good
to me. I've pushed it.

Many thanks for your help!

--
Cedric

On Wed, 2010-10-13 at 22:34 +0200, Jacek Wolszczak wrote:
> Hi, 
> 
> As in the topic. I replaced some assert items with OSL equivalents.
> I also replaced #ifdef DBG_UTIL with #if OSL_DEBUG_LEVEL > 1 in
> accordance with some findings in opengrok and
> http://wiki.services.openoffice.org/wiki/Debug_Levels. 
> 
> Some additional questions. What should I replace DBG_ERROR with?
> 
> Should RTL_LOGFILE_CONTEXT_AUTHOR as in http://bit.ly/buiBlA be updated
> somehow as it contains a lot of hardcoded e-mail addresses?
> 
> Regards,
> 
> Jacek
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice




More information about the LibreOffice mailing list