[Libreoffice] [LibreOffice][PATCH] compiler warnings inftxt.hxx

Michael Meeks michael.meeks at novell.com
Sat Oct 16 13:25:12 PDT 2010

On Sat, 2010-10-16 at 01:01 +0200, Kenneth Venken wrote:
> some "shadows a member of 'this'" and "unused parameter" warnings.

	Great :-) though compile warnings in binfilter are less problematic
than elsewhere, since it is known-awful, legacy code that most people
don't use. But I've pushed it - thanks.

> i've added an underscore prefix to the parameters that shadowed the
> members. Are there any naming conventions i should know of? 

	That's fine.

> what is the correct way to handle the "unused parameter" warnings?
> In this case the whole function probably isn't used so i guess the
> function could be removed?

	Removing the parameters is great, and/or removing the function as you
suggest - perhaps Caolan's call-catcher doesn't catch un-used inline
functions so well; quite possibly remove & compile-testing them is a
good plan.



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list