[Libreoffice] [LibreOffice][PATCH] compiler warnings inftxt.hxx

Caolán McNamara caolanm at redhat.com
Mon Oct 18 02:58:05 PDT 2010

On Sat, 2010-10-16 at 01:01 +0200, Kenneth Venken wrote:
> some "shadows a member of 'this'" and "unused parameter" warnings.

The binfilter is rather unloved, its effectively a copy of older
versions of sw/sd/sc and their dependencies, so if you see a warning in
binfilter and want to fix it, you can have a quick look at the
equivalent sw/sd/sc dir and see what fix was used there.

> i've added an underscore prefix to the parameters that shadowed the
> members. Are there any naming conventions i should know of? 
> what is the correct way to handle the "unused parameter" warnings?

void foo(bool thing) { }

thing unused! warning

Safest fix is e.g.

void foo(bool /*thing*/) {}

C++ allow this. Handy for the general case.


More information about the LibreOffice mailing list