[Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts
dtardon at redhat.com
Sun Apr 3 23:32:29 PDT 2011
On Fri, Apr 01, 2011 at 04:36:03AM -0600, Tor Lillqvist wrote:
> > I checked manually if the number was in the file. I didn't check
> > further, as I don't know a way to do that.
> OK. I don't know of any clever direct way either, but using http://opengrok.libreoffice.org/more/libs-core/svx/inc/svx/dialogs.hrc?full=RID_SVX_START++296 and http://opengrok.libreoffice.org/more/libs-core/svx/inc/svx/dialogs.hrc?full=RID_SVX_START++289 I found that the RID_SVX_START+296 and RID_SVX_START+289 values apparently already *are* taken. See http://opengrok.libreoffice.org/xref/libs-core/svx/inc/svx/dialogs.hrc#108 and http://opengrok.libreoffice.org/xref/libs-core/svx/inc/svx/dialogs.hrc#188 . Whether this overlap with your added RID_* values is a problem or not, I have no idea, sorry.
> I hope some of our more clueful list members can enlighten us...
AFAIK this does not matter if the resources come from different resource
files. E.g., if one uses CUI_RES(RID_FROBNICATE) in cui and
SVX_RES(RID_KABOOZLE) in svx, different resources are returned even if
RID_FROBNICATE and RID_KABOOZLE happen to have the same numeric value.
(Marginal note: I have spotted at least one RID_ decl. in
svx/inc/svx/dialogs.hrc (RID_SVXPAGE_MEASURE) that appears to be unused
in svx and is defined in .src file in cui; the decl. should probably be
moved there too.)
More information about the LibreOffice