[Libreoffice] [PATCH] [PUSHED] Improvement of Adding and Removing Color Charts

Tor Lillqvist tlillqvist at novell.com
Mon Apr 4 02:09:59 PDT 2011

> AFAIK this does not matter if the resources come from different resource
> files.

OK, good.

It would be a good idea then to stop even trying to have the RIDs not overlap for cases where it doesn't matter, I think?

Instead just clearly add a comment where RIDs are defined that "these values are relevant only for resource file xxx, and thus can overlap with RIDs defined elsewhere" or something? Perhaps split up the definitions to be in one file per resource file, with intentional overlap, if it doesn't matter?

Or am I misunderstanding, very likely...

I wonder if OOo is doing some work on getting rid of this silly game of "pick a unique number even if it doesn't have to be always unique, but still maybe good if it usually is". A dynamic assignment of numbers to resources named by *strings* would be cool.

Anyway, pushed the patch now then, to the master branch.  Thanks! Will push to the 3.4 branch, too, once I have such a tree set up.


More information about the LibreOffice mailing list