[Libreoffice] [partial PATCH] Easy hack: expunge duplicate enumerations in vcl
Caolán McNamara
caolanm at redhat.com
Tue Apr 5 12:18:02 PDT 2011
On Tue, 2011-04-05 at 21:01 +0200, Christina Roßmanith wrote:
> removed some methods ToFontWidth() which aren't needed anymore.
Yup, looks good, the removal of those redundant mappings is the target.
> After that vcl compiles fine for me. But it
> tells me that KDE is disabled (who did that?), so this part isn't
> checked by the compiler.
see --enable-kde/--enable-kde4 as arguments to ./autogen.sh / configure
> If someone could please review this patch. If it is fine I'll go on.
> Would you recommend a huge push at the end of this work or one for each
> removed enum?
Looks good, obviously remove the commented out code. Just the one push
IMO for the three enums.
C.
More information about the LibreOffice
mailing list