[Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

Thorsten Behrens thb at documentfoundation.org
Mon Apr 11 07:55:37 PDT 2011

Noel Power wrote:
> >As far as I understand the code it consists merely of test calls
> >to functions in order to see if they return a valid result. I'm
> >quite sure that you already know whether it has side effects or
> >not... I vote for "it hasn't", but I'm absolutely not sure
> nah, just seems like some testing to see if uno is bootstrapped and
> the ucp stuff available, it looks to me especially in the case you
> removed to be completely useless.
> Btw if you are feeling frisky and wish to kill other related pieces
> of uselessness :-) there are the  #ifdef _USE_UNO associated blocks
> that you can see around the hasUno() method ( and others ) that need
> some removing ( afaics _USE_UNO is defined always )
So we're safe to apply the original patch (with the improvements
suggested previously)?


-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110411/61fbcc65/attachment.pgp>

More information about the LibreOffice mailing list