[Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL
nopower at novell.com
Tue Apr 12 01:49:46 PDT 2011
On 11/04/11 15:55, Thorsten Behrens wrote:
> Noel Power wrote:
>>> As far as I understand the code it consists merely of test calls
>>> to functions in order to see if they return a valid result. I'm
>>> quite sure that you already know whether it has side effects or
>>> not... I vote for "it hasn't", but I'm absolutely not sure
>> nah, just seems like some testing to see if uno is bootstrapped and
>> the ucp stuff available, it looks to me especially in the case you
>> removed to be completely useless.
>> Btw if you are feeling frisky and wish to kill other related pieces
>> of uselessness :-) there are the #ifdef _USE_UNO associated blocks
>> that you can see around the hasUno() method ( and others ) that need
>> some removing ( afaics _USE_UNO is defined always )
> So we're safe to apply the original patch (with the improvements
> suggested previously)?
I'm pretty sure Christina pushed the patch to do with the
_OLD_FILE_IMPL IIRC Christina was going to squash the _USE_UNO pieces
too, not sure if that happened yet or not, Christina did you get a
chance to do that or should we maybe add it as an easy hack if you
didn't have time?
More information about the LibreOffice