[Libreoffice] DDEInitiate bug
michael.meeks at novell.com
Mon Aug 1 08:27:10 PDT 2011
On Mon, 2011-08-01 at 13:26 +0200, Knut Olav Bøhmer wrote:
> Now that I have my DDEInitiate-bug-workaround tested (and it works) I
> have some more time to do this.
ooh nice :-) It'd help to have the real number though:
> I have updated the bug-report at
also - if you add a [PATCH] subject line to your mail, you can be sure
of review, without that it is harder to get people interested.
> I think I should first find a solution to the DDEInitiate bug in
> LibreOffice, then I could start to work on the icon isssue.
> It sounds doable, as I can look in to what the Gtk version does.
> Should the icon-issue be registered in the bugtracking system?
Nah - just as long as someone is working on it, it is fine - we like to
discuss patches here. If you're going to dig into it, I'll dig out more
details I wrote up for someone else, just appended them: hopefully they
make the solution easy - just a matter of a bit of hacking, and some
Win32 build/testing :-)
All the best,
It seems that if I apply the attached patch, I end up with an
soffice.bin that is 7Kb instead of 7Mb ;-) that should be able to save
us - oh, 3 to 6Mb of Win32 installer space (which we can use for other
It seems that the problem is purely that we ram 7Mb of resource files
(primarily the .ico files I suspect) into both the 'fast
loader' (officeloader -> soffice.exe) and also soffice.bin.
Now; naturally this break something - the window icons when running
soffice.bin; so I have a few questions:
a) can we make vcl/win/source/window/salframe.cxx (SetIcon)
use a resource / Bitmap to set that, much like we do
already with the gtk+ equivalent
b) are these .icos (on a .bin file) used for anything else ?
[ can we easily audit that ? ].
c) Why are they -so- huge in the first instance ?
are dozens (cf. the verinfo.rc) of un-compressed 256x256
icons really necessary ? - they live in
+ does windows -really- not have some compressed
alternative somewhere here ?
+ how can this one set of .ico files be bigger than
an entire icon theme for the rest of LO ;-)
Anyhow - clearly, we can leave one lot of bloat hanging around in the
officeloader (soffice.exe) as long as we dung it out in the other and
save that installer space I suppose.
@@ -74,7 +74,7 @@
.IF "$(GUI)" == "WNT"
@@ -105,8 +105,8 @@
.IF "$(GUI)" == "WNT"
.ENDIF # WNT
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice