[Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

Miklos Vajna vmiklos at frugalware.org
Wed Aug 3 03:47:13 PDT 2011

On Tue, Aug 02, 2011 at 05:51:49PM +0100, Noel Power <nopower at novell.com> wrote:
> On 02/08/11 16:46, Miklos Vajna wrote:
> > I guess the reason is that the doc shell points to the whole document, 
> > while you usually export only part of the doc during copy&paste export. 
> 'copy&paste export' is it a new thing you can't normally do from writer 
> ? ( not familiar with it anyway )

No, it's not new at all. The only recent change was that you changed
SwMSConvertControls to require a valid SwDocShell. Given that
SwMSConvertControls is called by MSWordExportBase, and copy&paste export
(when RTF format is selected and which uses MSWordExportBase) does not
provide a SwDocShell (AFAIK it never did, but it wasn't a problem till

> > And yes, I don't think missing the control export is a big issue (at 
> > least it's a smaller one thatn the current instant crash), 
> yes of course and no problem for me with the fix for that

OK, I've pushed the patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110803/287c95d5/attachment.pgp>

More information about the LibreOffice mailing list