[Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

Noel Power nopower at novell.com
Wed Aug 3 04:50:05 PDT 2011

Hi Miklos,
On 03/08/11 11:47, Miklos Vajna wrote:
> On Tue, Aug 02, 2011 at 05:51:49PM +0100, Noel Power<nopower at novell.com>  wrote:
>> On 02/08/11 16:46, Miklos Vajna wrote:
>>> I guess the reason is that the doc shell points to the whole document,
>>> while you usually export only part of the doc during copy&paste export.
>> 'copy&paste export' is it a new thing you can't normally do from writer
>> ? ( not familiar with it anyway )
> No, it's not new at all. The only recent change was that you changed
> SwMSConvertControls to require a valid SwDocShell.
doh, yes of course I made a change that requires the doc shell to be 
used immediately (even for export ) <sigh>

>> yes of course and no problem for me with the fix for that
> OK, I've pushed the patch.
cool, I'd like to reorganize that at some stage soon so we can remove 
that check you put in.


More information about the LibreOffice mailing list