[Libreoffice] curiosity in OResultSet.cxx

Caolán McNamara caolanm at redhat.com
Fri Aug 5 08:03:50 PDT 2011


On Fri, 2011-07-29 at 17:00 +0100, Caolán McNamara wrote:
> On Fri, 2011-07-29 at 11:21 -0400, Terrence Enger wrote:
> > libs-core/connectivity/source/drivers/odbcbase/OResultSet.cxx
> > has a line which raises my suspicions.
> 
> > Is the scalar delete really intended?  If so, it might be
> > worth a comment just to humour paranoids like me.
> 
> nah, the delete in OResultSet::setFetchSize is just bogus IMO and should
> be delete[]. Your discovery, send in the obvious patch for glory.

Fair enough, patched it myself :-)

C.



More information about the LibreOffice mailing list