[Libreoffice] [PUSHED] Gtk3 button rendering

Michael Meeks michael.meeks at novell.com
Wed Aug 17 06:57:56 PDT 2011

Hi Lucas,

On Tue, 2011-08-16 at 21:13 +0200, Lucas Baudin wrote:
> Here is a patch to render gtk3 button correctly. I send it now because I
> won't have internet until tuesday, and it would be a bit stupid if
> anyone made the same thing... So, you are aware that the patch exists,
> if you need it :)

	Hey :-) That's fine - hope you had a great break.

> So, there are some warnings about unused variables, of course, they will
> be used later. I didn't split drawNativeControl(), but I suppose it will
> be necessary later.

	Great - so, some quite intense gtk3 work is happening in the
feature/gtk3 branch - which is where I've merged your patch - thanks for
that ! incidentally, I disabled it in IsNativeControlSupported with a
#ifdef since I had a few issues with my theme & prelight / highlight

> I don't know if it is worth to apply it now (it is not finished at all),
> but it is under GPLv3+/MPL.

	Of course ! :-) good to get it in.

> I will try to complete to work again on gtk3 next week...

	I look forward to that :-) I'm working actively on feature/gtk3 but not
so much in this area: more core re-factoring and porting away from the X

	Thanks !


 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list