[Libreoffice] Rectangle width

Michael Meeks michael.meeks at novell.com
Thu Aug 18 02:21:30 PDT 2011


On Wed, 2011-08-17 at 23:08 +0200, Thorsten Behrens wrote:
> Hi Dmitry - yes, the two different methods are surely confusing. As
> for the "wrong value", that very much depends on the mental model of
> rectangles you're using. In a discrete geometry world (aka "pixel"),
> the GetWidth() is correct. In a continuous geometry world (aka
> "euclidean plane"), getWidth() is right.

	Ho ;-) Should we perhaps have some better naming: 'getOuterWidth' vs.
'getWidth' or something ;-)

> This fundamental, conceptual difference is the historical reason for
> the two methods (admittedly, not a very clean solution to the
> problem).

	True - perhaps we should audit all calls of GetWidth on Rectangle to
see how many there are and update them if fewer than a couple of hundred
or so ?

	ATB,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list