[Libreoffice] [REVIEW] Patch for #36800: "Find & replace" does not search single cell

[Kohei Yoshida]

On Mon, 2011-08-22 at 14:49 +0200, Petr Mladek wrote:

> I did a quick look and the patch looks suspicious to me. The code is
> like:
> 
> if
>     if
>         nCol--;
>     else
> 	nRow--;
>     fi
> else
>     if
> 	nCol++;
>     else
> 	nRow++;
> fi
> 
> Your patch remove only the first nCol--. It looks a bit asymmetric. Of
> course, it might be correct but...

I had already commented in bugzilla, but the patch not only breaks the
symmetry it changes the expected behavior.  So, it's not the right way
to fix it.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida at suse.com>