[Libreoffice] [REVIEW] Patch for #36800: "Find & replace" does not search single cell
kohei.yoshida at suse.com
Mon Aug 22 08:29:52 PDT 2011
On Mon, 2011-08-22 at 09:13 -0400, Kohei Yoshida wrote:
> > Your patch remove only the first nCol--. It looks a bit asymmetric. Of
> > course, it might be correct but...
> I had already commented in bugzilla, but the patch not only breaks the
> symmetry it changes the expected behavior. So, it's not the right way
> to fix it.
Also, when working on this EasyHack, please do
1) try to check the size of the current selection at the start of the
method, and if the selection contains only one cell, check that cell,
and return immediately, and
2) do test all the find and replace functionality to make sure nothing
is broken. This means you need to familiarize yourself with what the
current functionality is, what options are available so that you can
test it thoroughly using various search options. In the latest code
Ctrl-F is bound to the find bar, so you need to launch the old dialog by
Ctrl-Alt-F or from the menu Edit - Find & Replace... and see what search
options are available there.
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida at suse.com>
More information about the LibreOffice