[Libreoffice] [PATCH] some refactoring in xmlcelli.cxx

Kohei Yoshida kohei.yoshida at gmail.com
Sat Aug 27 11:09:35 PDT 2011

Hi Markus,

On Sat, Aug 27, 2011 at 9:24 AM, Markus Mohrhard
<markus.mohrhard at googlemail.com> wrote:

> It would be nice if someone could give it a quick review before I push it.

Looks good to me.  The second hunk was a bit hard to grok, but I came
to the same conclusion as you did.

> Especially the long if statement is a bit tricky but I think that only the
> first line was needed.

Yup.  I agree.  Suffice it to say that that if statement is one of the
stinkiest I've seen in this code base.


More information about the LibreOffice mailing list