[Libreoffice] [PATCH] some refactoring in xmlcelli.cxx

[Eike Rathke]

Hi Markus,

On Saturday, 2011-08-27 15:24:31 +0200, Markus Mohrhard wrote:

> -                    if (     (!pOUTextContent && !pOUText && !pOUTextValue)
> -                        && ( (pOUTextContent && !pOUTextContent->getLength()) || !pOUTextContent )
> -                        && ( (pOUText && !pOUText->getLength()) || !pOUText )
> -                        && ( (pOUTextValue && !pOUTextValue->getLength()) || !pOUTextValue ))
> +                    if (!pOUTextContent && !pOUText && !pOUTextValue)

Might it be that the original intention was

                       if (     (!pOUTextContent && !pOUText && !pOUTextValue)
                           || ( (pOUTextContent && !pOUTextContent->getLength()) || !pOUTextContent )
                           || ( (pOUText && !pOUText->getLength()) || !pOUText )
                           || ( (pOUTextValue && !pOUTextValue->getLength()) || !pOUTextValue ))

instead? Just from looking at it, without having seen the context
around..

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110827/382888f3/attachment.pgp>