[Libreoffice] code simplification: please logic review, to be sure

Eike Rathke ooo at erack.de
Sat Aug 27 14:18:09 PDT 2011


Hi Pierre-André,

On Friday, 2011-08-26 22:23:07 +0200, Pierre-André Jacquod wrote:

> But this basically, this just ensure that the return value is not
> NULL (comparing the pointer SwFrm* with 0 )
> 
> So I though the final version to be:
> if( 0 != ( pONd = aIdx.GetNode().GetOLENode() ) &&
>             aName.Equals( pONd->GetChartTblName() ) &&
>             pONd->getLayoutFrm( rVSh.GetLayout()         )
>         {....
>         }
> 
> Did I missed something with my logic ?

No, looks fine.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110827/4b8e0afd/attachment.pgp>


More information about the LibreOffice mailing list