[Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog

Kohei Yoshida kohei.yoshida at suse.com
Tue Aug 30 13:55:37 PDT 2011


Hi there,

I'd like to have 

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca

cherry-picked to the 3.4 branch.  A patch for this commit is attached as
well for convenience.

This fixes a slight layout problem in the main pivot table dialog, where
the text "Drag the fields from the right into the desired position"
appeared overlapping the row and data field areas on Windows XP.  This
commit fixes it.  On platforms other than Windows XP there is no such
issue.

Apparently our dialogs get vertically compressed on Windows XP (for
whatever reason).  And because the size and position of the
page/row/column/data field areas are absolute, this caused the layout
breakage on XP.

Review & sign-off appreciated.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida at suse.com>


More information about the LibreOffice mailing list