[Libreoffice] [PATCH] configure.in examples: options shouldn't have quote

Korrawit Pruegsanusak detective.conan.1412 at gmail.com
Sat Dec 10 20:47:02 PST 2011

Hello all,

I've attached two cosmetic patches of configure.in.
First patch fixes an example in AS_HELP_STRING. The configure options
shouldn't be passed with quotation marks, as described in commit
But I'm not sure whether it's correct or apply to all platform. So, I
sent it here for a review.

Second patch is just a trivial change: --with-theme is without "s".

Last but not least, I've noticed that there are two themes, classic
and industrial, that described in AS_HELP_STRING (see context in first
patch) but not detected while checking (see context in second patch).
That is, if user pass e.g. --with-theme=classic, it'll fail. So, do we
really support classic and industrial themes? I've found them listed
on ooo_custom_images [1], but I'm not sure if it's relevant.

[1] http://opengrok.libreoffice.org/xref/core/ooo_custom_images/

Please feel free to comment :)
Best Regards,
Korrawit Pruegsanusak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-These-options-shouldn-t-be-passed-with-quotation-mar.patch
Type: application/octet-stream
Size: 1710 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111211/f8eae40d/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-with-theme-is-without-trailing-s.patch
Type: application/octet-stream
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111211/f8eae40d/attachment-0001.obj>

More information about the LibreOffice mailing list