[Libreoffice] [PARTIAL-PUSHED] [PATCH] configure.in examples: options shouldn't have quote

Lionel Elie Mamane lionel at mamane.lu
Sat Dec 10 23:28:32 PST 2011

On Sun, Dec 11, 2011 at 11:47:02AM +0700, Korrawit Pruegsanusak wrote:

> I've attached two cosmetic patches of configure.in.  First patch
> fixes an example in AS_HELP_STRING. The configure options shouldn't
> be passed with quotation marks, as described in commit message.

Well, IMHO the example is correct _with_ quotation marks, else the
shell will cut it into several arguments.

For example:

 ./autogen.sh --with-theme=oxygen tango


$ ./autogen.sh --with-theme=oxygen tango
running ./configure with '--with-theme=oxygen' 'tango'
configure: WARNING: you should use --build, --host, --target
*   Running LibreOffice build configuration.

checking build system type... Invalid configuration `tango': machine `tango' not recognized
configure: error: /bin/bash ./config.sub tango failed
Error running configure at ./autogen.sh line 157.

On which platform have you encountered the "it breaks with quotation
marks, but works without quotation marks" behaviour you mention?

> Second patch is just a trivial change: --with-theme is without "s".

Yes, applied this one. Thanks!


More information about the LibreOffice mailing list