[Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

Michael Meeks michael.meeks at suse.com
Tue Dec 13 04:09:24 PST 2011

Hi Ivan,

On Mon, 2011-12-12 at 23:54 +0400, Ivan Timofeev wrote:
> the bug: https://bugs.freedesktop.org/show_bug.cgi?id=41264
> briefly: in the context menus (except the toolbar's ones) icons are not 
> shown for radio menu items and for checked menu items.

	That - is/was a feature. In the gtk+ world when a menu item is a radio
or option button, it has a [ ] or [x] checked - which is in the same
column as an icon would be for a normal item.

	In various other toolkits and suites things can be done differently,
but IMHO the above is a pleasant way to arrange menus that doesn't waste
space hideously. IIRC the Qt theme I worked on once, had no way of
knowing whether a menu item was check-able unless it was checked, and so
had some hideous fiddling with the icon to overcome this sort of
thing :-) Various versions of MS Office (as/when it had menus) had both
the check and an icon next to each item.

> [ By the way, what is svtools/source/control/toolbarmenu.cxx ? (the 
> drawing code is like in the vcl's menu.cxx ?) ]

	Goodness; another duplication ? it looks hideous - we should presuambly
unwind what the difference is to VCL's MenuBar, and collapse that out of
existence if it is truly mostly a duplicate.

> so, summing up :) I would like to remove the
> 	if ((nMenuFlags & MENU_FLAG_SHOWCHECKIMAGES) || !pData->HasCheck() )
> line and in general the MENU_FLAG_SHOWCHECKIMAGES flag, as I can't ever 
> understand why it has been introduced. Any counterarguments?

	See above ;-) if we want to do that, it would need a per-platform /
backend flag as well I think, so we don't do it for gtk+ and I'd not
want that for SUSE builds I think: it is hard enough getting from
File->New-> to the children of that menu item with the mouse anyway -
due to the menu's excessive width ;-)

	Does that make sense ?



michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list