[Libreoffice] fixing fdo#41264: no check marks in Line Spacing and ALignment popup menu

Ivan Timofeev timofeev.i.s at gmail.com
Wed Dec 14 08:20:05 PST 2011


14.12.2011 17:01, Michael Meeks пишет:
> On Wed, 2011-12-14 at 15:32 +0400, Ivan Timofeev wrote:
>> If I understood you right, the MENU_FLAG_SHOWCHECKIMAGES flag was
>> introduced to control whether a simple check mark [x] or an image should
>> be painted with a checkable menu item; if it is so, it don't work anyway.
>> But may be I missed some piece of logic again :)
>
> 	So - you're right; sorry for the noise ! :-) How does it look with your
> fix in place ? :-)

see the attaches :)

I've tweaked menu.cxx a bit and have added "Checkable = TRUE ; \" to 
some (not all) indigent menu items in sw/source/ui/app/mn.src, don't 
know whether this is a right solution. If so, we should very carefully 
visit all such src files.

And somehow we should enable MENU_FLAG_SHOWCHECKIMAGES for win I think. 
I have not enough time to do that now, crazy pre-session weeks have 
started! :)

Regards,
Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: refined-menu.png
Type: image/png
Size: 25711 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111214/bb8e9171/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-some-menu-drawing-problems.diff
Type: text/x-diff
Size: 4138 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111214/bb8e9171/attachment-0001.diff>


More information about the LibreOffice mailing list