[Libreoffice] [PATCH] [RFC] COMPRESSMODE_FULL

[Matteo Casalin]

Hi Thorsten,

On 12/16/2011 11:52 AM, Thorsten Behrens wrote:
> Matteo Casalin wrote:
>>  From my understanding, if we remove these 2 calls that set te
>> COMPRESSMODE_FULL flag then there is no reason to keep the code that
>> depend on that, unless the svstream acquires the flag from the stream
>> itself or that it's set by calling the set function with a "magic
>> number" instead of the #define.
>>
> Quite. Now really looking into what vcl/source/gdi/gdimtf.cxx does,
> the nStmCompressMode is *read* from the input, but then happily
> ignored - so the code, as it is, will already balk on thusly written
> files. The only other use I see is internal, i.e. within the same
> running LibO instance - so yeah, go&  kill this off! :)

Here are the patches for *completely* removing COMPRESSMODE_FULL 
support. I had to split them since I initially didn't clone binfilter, 
just did it for this patch and I'm not so skilled with git. Obviously a 
single patch would keep the whole LibO repo more consistent, feel free 
to hack these patches to your own taste.
A late thought was that I could have at least made the two commit logs 
different, I don't know if this can be done by hand. The smallest one is 
on binfilter, in any case.
Last notes:
* Modifications to core where "make"d and the process completes
   successfully;
* I also tried "make check" on core (for the first time), but it stops
   on "ulimit". I really don't know if this due to these patches or was
   already there;
* Modifications to binfilter where not tested at all, not even compiled.

Cheers
Matteo

PS: I already sent (some time ago) a license statement for (future) 
contributions.

> Cheers,
>
> -- Thorsten
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice