[Libreoffice] [PATCH] Fix fdo#39639 [EasyHack] Fix duplicate longname IDs

Jan Holesovsky kendy at suse.cz
Tue Dec 20 07:51:52 PST 2011


Hi Victor,

On 2011-12-20 at 17:34 +0900, Victor Lee wrote:

> the attached patch simply removes duplicated and unused IDs in
> BackgroundsDialog.

Thank you for the patch, and welcome to LibreOffice! :-)

Just wanted to ask you how did you find these?  I mean, it seems to me
that "HID:WIZARDS_HID_BG_BTN_IMG12" is not used either [or is it?], so
why exactly do you remove only IMG13 and above, and not all the
HID:WIZARDS_HID_BG_BTN_IMG*?

Regarding the patch itself, it would be great if you can use the output
of git format-patch as described here:

http://wiki.documentfoundation.org/Development#Preparing_patches

Thank you a lot,
Kendy



More information about the LibreOffice mailing list