[Libreoffice] [PATCH] Fix fdo#39639 [EasyHack] Fix duplicate longname IDs

Victor Lee konya.vic at gmail.com
Sat Dec 24 08:41:59 PST 2011


Hi Kendy,

I've reformatted the patch.
The reason for deleting these IDs is stated here:
https://bugs.freedesktop.org/show_bug.cgi?id=39639

Sorry for the late reply, and thank you for the advice!
This is my first EasyHack.

Victor Lee

On Wed, Dec 21, 2011 at 12:51 AM, Jan Holesovsky <kendy at suse.cz> wrote:
> Hi Victor,
>
> On 2011-12-20 at 17:34 +0900, Victor Lee wrote:
>
>> the attached patch simply removes duplicated and unused IDs in
>> BackgroundsDialog.
>
> Thank you for the patch, and welcome to LibreOffice! :-)
>
> Just wanted to ask you how did you find these?  I mean, it seems to me
> that "HID:WIZARDS_HID_BG_BTN_IMG12" is not used either [or is it?], so
> why exactly do you remove only IMG13 and above, and not all the
> HID:WIZARDS_HID_BG_BTN_IMG*?
>
> Regarding the patch itself, it would be great if you can use the output
> of git format-patch as described here:
>
> http://wiki.documentfoundation.org/Development#Preparing_patches
>
> Thank you a lot,
> Kendy
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-duplicated-and-unused-IDs.patch
Type: application/octet-stream
Size: 4814 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111225/93850f61/attachment-0001.obj>


More information about the LibreOffice mailing list