[Libreoffice] [REVIEW] Easy patch on l10ntools

julien2412 serval2412 at yahoo.fr
Wed Dec 28 14:31:21 PST 2011


Cppcheck report tells this :
1474	duplicateBranch	style	Found duplicate branches for if and else
for l10ntools/source/export.cxx

Even if this seems easy, perhaps it could be something else than just
"rText" here.

diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index bd1fbfb..fbed184 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -1475,7 +1475,7 @@ void Export::InsertListEntry( const ByteString &rText,
const ByteString &rLine )
             (*pCurEntry)[ SOURCE_LANGUAGE ] = rLine;
-            (*pCurEntry)[ SOURCE_LANGUAGE ] = rLine;
+            (*pCurEntry)[ SOURCE_LANGUAGE ] = rText;

Your opinion ?

PS : if ok, I can of course commit and push on master 

View this message in context: http://nabble.documentfoundation.org/REVIEW-Easy-patch-on-l10ntools-tp3617480p3617480.html
Sent from the Dev mailing list archive at Nabble.com.

More information about the LibreOffice mailing list